removed reliance on built-in django ModelForms from templates/core/base.html, apps.dashboard.forms, .tests.test_forms & .test_views
This commit is contained in:
@@ -8,12 +8,6 @@ from ..forms import (
|
||||
from ..models import Item, List
|
||||
|
||||
class ItemFormTest(TestCase):
|
||||
def test_form_item_has_placeholder_and_css_classes(self):
|
||||
form = ItemForm()
|
||||
rendered = form.as_p()
|
||||
self.assertIn('placeholder="Enter a to-do item"', rendered)
|
||||
self.assertIn('class="form-control form-control-lg"', rendered)
|
||||
|
||||
def test_form_validation_for_blank_items(self):
|
||||
form = ItemForm(data={"text": ""})
|
||||
form.save()
|
||||
@@ -23,15 +17,6 @@ class ItemFormTest(TestCase):
|
||||
self.assertFalse(form.is_valid())
|
||||
self.assertEqual(form.errors["text"], [EMPTY_ITEM_ERROR])
|
||||
|
||||
def test_invalid_form_has_bootstrap_is_invalid_css_class(self):
|
||||
form = ItemForm(data={"text": ""})
|
||||
self.assertFalse(form.is_valid())
|
||||
field = form.fields["text"]
|
||||
self.assertEqual(
|
||||
field.widget.attrs["class"],
|
||||
"form-control form-control-lg is-invalid",
|
||||
)
|
||||
|
||||
def test_form_save_handles_saving_to_a_list(self):
|
||||
mylist = List.objects.create()
|
||||
form = ItemForm(data={"text": "do re mi"})
|
||||
@@ -41,11 +26,6 @@ class ItemFormTest(TestCase):
|
||||
self.assertEqual(new_item.list, mylist)
|
||||
|
||||
class ExistingListItemFormTest(TestCase):
|
||||
def test_form_renders_item_text_input(self):
|
||||
list_ = List.objects.create()
|
||||
form = ExistingListItemForm(for_list=list_)
|
||||
self.assertIn('placeholder="Enter a to-do item"', form.as_p())
|
||||
|
||||
def test_form_validation_for_blank_items(self):
|
||||
list_ = List.objects.create()
|
||||
form = ExistingListItemForm(for_list=list_, data={"text": ""})
|
||||
|
||||
@@ -50,7 +50,7 @@ class NewListTest(TestCase):
|
||||
response = self.post_invalid_input()
|
||||
self.assertContains(response, html.escape(EMPTY_ITEM_ERROR))
|
||||
|
||||
class DashViewTest(TestCase):
|
||||
class ListViewTest(TestCase):
|
||||
def test_uses_list_template(self):
|
||||
mylist = List.objects.create()
|
||||
response = self.client.get(f'/apps/dashboard/{mylist.id}/')
|
||||
@@ -122,6 +122,12 @@ class DashViewTest(TestCase):
|
||||
response = self.post_invalid_input()
|
||||
self.assertContains(response, html.escape(EMPTY_ITEM_ERROR))
|
||||
|
||||
def test_for_invalid_input_sets_is_invalid_class(self):
|
||||
response = self.post_invalid_input()
|
||||
parsed = lxml.html.fromstring(response.content)
|
||||
[input] = parsed.cssselect("input[name=text]")
|
||||
self.assertIn("is-invalid", set(input.classes))
|
||||
|
||||
def test_duplicate_item_validation_errors_end_up_on_lists_page(self):
|
||||
list1 = List.objects.create()
|
||||
Item.objects.create(list=list1, text="lorem ipsum")
|
||||
|
||||
Reference in New Issue
Block a user